Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Agones custom kinds to the Allow-List #4488

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Add Agones custom kinds to the Allow-List #4488

merged 2 commits into from
Jul 17, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jul 17, 2020

Fixes #4486

@dgageot dgageot requested a review from a team as a code owner July 17, 2020 08:55
@dgageot dgageot requested a review from gsquared94 July 17, 2020 08:55
@codecov
Copy link

codecov bot commented Jul 17, 2020 •
edited
Loading

Codecov Report

Merging #4488 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4488   +/-   ##
=======================================
  Coverage   72.35%   72.35%           
=======================================
  Files         333      333           
  Lines       12944    12944           
=======================================
  Hits         9366     9366           
  Misses       2981     2981           
  Partials      597      597
Impacted Files Coverage Δ
pkg/skaffold/deploy/kubectl/visitor.go 95.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da54a9a...0c29b07. Read the comment docs.

@dgageot dgageot merged commit 867e1df into GoogleContainerTools:master Jul 17, 2020
@fmotrifork fmotrifork mentioned this pull request Aug 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis approved these changes

@gsquared94 gsquared94 Awaiting requested review from gsquared94

Assignees
No one assigned
Labels
cla: yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image rewriting fails
3 participants
@dgageot @briandealwis @googlebot