Add Agones custom kinds to the Allow-List (#4488)

* Support `agones.dev/Fleet` kind Signed-off-by: David Gageot <[email protected]> * Support `agones.dev/GameServer` kind Signed-off-by: David Gageot <[email protected]>
GoogleContainerTools · Jul 17, 2020 · 867e1df · 867e1df
1 parent 1600809
commit 867e1df
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/pkg/skaffold/deploy/kubectl/visitor.go b/pkg/skaffold/deploy/kubectl/visitor.go
@@ -24,8 +24,8 @@ import (
 	"github.com/GoogleContainerTools/skaffold/pkg/skaffold/yaml"
 )
 
-// transformableWhitelist is the set of kinds that can be transformed by Skaffold.
-var transformableWhitelist = map[apimachinery.GroupKind]bool{
+// transformableAllowlist is the set of kinds that can be transformed by Skaffold.
+var transformableAllowlist = map[apimachinery.GroupKind]bool{
 	{Group: "", Kind: "Pod"}:                        true,
 	{Group: "apps", Kind: "DaemonSet"}:              true,
 	{Group: "apps", Kind: "Deployment"}:             true, // v1beta1, v1beta2: deprecated in K8s 1.9, removed in 1.16
@@ -37,6 +37,8 @@ var transformableWhitelist = map[apimachinery.GroupKind]bool{
 	{Group: "extensions", Kind: "Deployment"}:       true, // v1beta1: deprecated in K8s 1.9, removed in 1.16
 	{Group: "extensions", Kind: "ReplicaSet"}:       true, // v1beta1: deprecated in K8s 1.9, removed in 1.16
 	{Group: "serving.knative.dev", Kind: "Service"}: true,
+	{Group: "agones.dev", Kind: "Fleet"}:            true,
+	{Group: "agones.dev", Kind: "GameServer"}:       true,
 }
 
 // FieldVisitor represents the aggregation/transformation that should be performed on each traversed field.
@@ -104,7 +106,7 @@ func shouldTransformManifest(manifest map[string]interface{}) bool {
 		Kind:  gvk.Kind,
 	}
 
-	return transformableWhitelist[groupKind]
+	return transformableAllowlist[groupKind]
 }
 
 // recursiveVisitorDecorator adds recursion to a FieldVisitor.