Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Add proto.ActionableErr to diag.Resource and deploy.Resource.Status #4390

Merged
merged 3 commits into from
Jun 25, 2020
Merged

Refactor Add proto.ActionableErr to diag.Resource and deploy.Resource.Status #4390

merged 3 commits into from
Jun 25, 2020

Commits on Jun 24, 2020

  1. Refactor diag.Resource and deploy.Resource.Status to contain actionab… 

    …le error proto

proto.ActionableErr

In this PR,
1. For suggesting actionable errors for k8 infra errors, it would make
sense to do it in the diag package.
2. Hence adding ActionableErr to diag.Resource package and propogating to depoyment status in
skaffold.deploy.Resource.Status
    @tejal29
    tejal29 committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    bdea994 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. fix error status detection

    @tejal29
    tejal29 committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    9578754 View commit details
    Browse the repository at this point in the history

  2. change *proto.ActionableErr to proto.ActionableErr

    @tejal29
    tejal29 committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    270899b View commit details
    Browse the repository at this point in the history