Refactor Add proto.ActionableErr to diag.Resource and deploy.Resource.Status #4390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
force-pushed
the
add_infra_errors
branch
from
e79d216
to
48066e3
Compare
…le error proto proto.ActionableErr In this PR, 1. For suggesting actionable errors for k8 infra errors, it would make sense to do it in the diag package. 2. Hence adding ActionableErr to diag.Resource package and propogating to depoyment status in skaffold.deploy.Resource.Status
tejal29
force-pushed
the
add_infra_errors
branch
from
48066e3
to
bdea994
Compare
Codecov Report
@@ Coverage Diff @@
## master #4390 +/- ##
==========================================
- Coverage 71.94% 71.87% -0.08%
==========================================
Files 325 325
Lines 12708 12722 +14
==========================================
+ Hits 9143 9144 +1
- Misses 2989 3000 +11
- Partials 576 578 +2
Continue to review full report at Codecov.
|
| return r.ae | ||
| } | ||
| func (r Resource) StatusUpdated(another Resource) bool { | ||
| return r.ae.ErrCode != another.ae.ErrCode |
There was a problem hiding this comment.
Should this code check if r.ae != nil && another.ae != nil ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have added the actionable error message to the diagnostics package.
For suggesting actionable errors for k8 infra errors, it would make sense to do it in the diag package.
Got rid of
detailsinskaffold.deploy.Resource.Statusto re-useproto.ActionableErr.Message.Adding ActionableErr to daig.Resource package and propagating to deployment status in
skaffold.deploy.Resource.Status
Most of the code changes are in test. Very minor changes in source code files.
Fixes: #nnn
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs
Description
User facing changes (remove if N/A)
Follow-up Work (remove if N/A)