Run container-structure-test on remote images #3983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
nkubala
reviewed
Apr 20, 2020
There was a problem hiding this comment.
I've been toying with the idea of adding more test runners recently, most likely a "custom" test runner to start. should we move this image pulling out of the structure test runner and up one level so we always pull remote images before running the entire test phase?
|
@nkubala I've moved the code up one level. |
dgageot
force-pushed
the
fix-3907
branch
2 times, most recently
from
bfe58e1 to
a02e629
Compare
Fixes GoogleContainerTools#3907 Fixes GoogleContainerTools#1082 Signed-off-by: David Gageot <[email protected]>
nkubala
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3907 and #1082
Signed-off-by: David Gageot [email protected]