Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How is the test phase working on GCB? #1082

Closed
dgageot opened this issue Oct 3, 2018 · 3 comments
Closed

How is the test phase working on GCB? #1082

dgageot opened this issue Oct 3, 2018 · 3 comments
Assignees
@dgageot @nkubala
Labels
area/testing Issues concerning the testing phase of Skaffold build/gcb kind/question User question

Comments

@dgageot
Copy link
Contributor

dgageot commented Oct 3, 2018

ping @nkubala
@dgageot dgageot added kind/question User question area/testing Issues concerning the testing phase of Skaffold labels Oct 3, 2018
@nkubala
Copy link
Contributor

nkubala commented Oct 4, 2018

We should be able to handle this by having the GCB client inject a build step that runs for each test type using a predefined "test image", e.g. gcr.io/gcp-runtimes/container-structure-test for structure tests, and a set of args that it knows how to pass to the build step. We might have to do a little workspace manipulation to make sure the test files get uploaded in the context before we kick off the build step but it should be doable

@nkubala
Copy link
Contributor

nkubala commented Oct 4, 2018

I suppose we could also support a testImage field or something similar that can be specified in the skaffold.yaml, but I think for most (if not all) cases this should be an implementation detail and not something the user will need to change

@nkubala nkubala self-assigned this Oct 4, 2018
@dgageot dgageot mentioned this issue Apr 20, 2020
Closed
dgageot added a commit to dgageot/skaffold that referenced this issue Apr 20, 2020
@dgageot
Run container-structure-test on remote images
728493e 
Fixes GoogleContainerTools#3907
Fixes GoogleContainerTools#1082

Signed-off-by: David Gageot <[email protected]>
@dgageot dgageot self-assigned this Apr 20, 2020
@dgageot dgageot mentioned this issue Apr 20, 2020
Merged
@tstromberg
Copy link
Contributor

This could use a clearer issue title. It's unclear what the intended outcome of this issue is.

dgageot added a commit to dgageot/skaffold that referenced this issue Apr 21, 2020
@dgageot
Run container-structure-test on remote images
2a09a3b 
Fixes GoogleContainerTools#3907
Fixes GoogleContainerTools#1082

Signed-off-by: David Gageot <[email protected]>
dgageot added a commit to dgageot/skaffold that referenced this issue Apr 21, 2020
@dgageot
Run container-structure-test on remote images
bfe58e1 
Fixes GoogleContainerTools#3907
Fixes GoogleContainerTools#1082

Signed-off-by: David Gageot <[email protected]>
dgageot added a commit to dgageot/skaffold that referenced this issue Apr 21, 2020
@dgageot
Run container-structure-test on remote images
a02e629 
Fixes GoogleContainerTools#3907
Fixes GoogleContainerTools#1082

Signed-off-by: David Gageot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgageot dgageot

@nkubala nkubala

Labels
area/testing Issues concerning the testing phase of Skaffold build/gcb kind/question User question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tstromberg @dgageot @nkubala