Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support go Templates in Custom Builder commands #3754

Merged
merged 4 commits into from
Feb 28, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Feb 28, 2020

Fixes #3753

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #3754 into master will increase coverage by 0.01%.
The diff coverage is 84.21%.

Impacted Files Coverage Δ
pkg/skaffold/docker/image.go 73.89% <100%> (+0.53%) ⬆️
pkg/skaffold/util/env_template.go 100% <100%> (ø) ⬆️
pkg/skaffold/build/misc/env.go 100% <100%> (+12.5%) ⬆️
pkg/skaffold/deploy/helm.go 77.47% <100%> (+0.29%) ⬆️
pkg/skaffold/build/custom/script.go 52.38% <40%> (-1.47%) ⬇️
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️
pkg/skaffold/sync/sync.go 72.57% <0%> (+0.31%) ⬆️

@tejal29 tejal29 self-assigned this Feb 28, 2020
@dgageot dgageot merged commit c2877a6 into GoogleContainerTools:master Feb 28, 2020
@nkubala
Copy link
Contributor

nkubala commented Feb 29, 2020

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Go templates in custom command declaration
4 participants