Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Go templates in custom command declaration #3753

Closed
dgageot opened this issue Feb 28, 2020 · 0 comments · Fixed by #3754
Closed

Support Go templates in custom command declaration #3753

dgageot opened this issue Feb 28, 2020 · 0 comments · Fixed by #3754
Assignees
@dgageot
Labels
build/custom kind/feature-request

Comments

@dgageot
Copy link
Contributor

dgageot commented Feb 28, 2020

It would be useful to support Go templates in Custom Artifact's build command. It is especially useful for one-liner commands.
dgageot added a commit to dgageot/skaffold that referenced this issue Feb 28, 2020
@dgageot
Support Go Templates in command
84254e3 
Fixes GoogleContainerTools#3753

Signed-off-by: David Gageot <[email protected]>
@dgageot dgageot mentioned this issue Feb 28, 2020
Merged
@dgageot dgageot self-assigned this Feb 28, 2020
dgageot added a commit that referenced this issue Feb 28, 2020
@dgageot @tejal29
Support go Templates in Custom Builder commands (#3754)
c2877a6 
* Remove duplication

Signed-off-by: David Gageot <[email protected]>

* Support Go Templates in command

Fixes #3753

Signed-off-by: David Gageot <[email protected]>

* Update documentation

Signed-off-by: David Gageot <[email protected]>

* Update docs/content/en/docs/pipeline-stages/builders/custom.md

Co-Authored-By: Tejal Desai <[email protected]>

Co-authored-by: Tejal Desai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgageot dgageot

Labels
build/custom kind/feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support go Templates in Custom Builder commands dgageot/skaffold
1 participant
@dgageot