Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestGracefulBuilCancel flake #3604

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 28, 2020

No description provided.

Ran the test 1000 times on TravisCI without issue.

Fix GoogleContainerTools#3537

Signed-off-by: David Gageot <[email protected]>
@dgageot dgageot changed the title Working on TestGracefulBuilCancel Fix TestGracefulBuilCancel flake Jan 29, 2020
@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #3604 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/build/misc/graceful.go 71.42% <0%> (-7.15%) ⬇️
pkg/skaffold/build/buildpacks/lifecycle.go 75% <0%> (-6.09%) ⬇️
pkg/skaffold/docker/image.go 75.67% <0%> (-0.69%) ⬇️

@dgageot dgageot merged commit e137ddc into GoogleContainerTools:master Jan 29, 2020
kissmikijr pushed a commit to kissmikijr/skaffold that referenced this pull request Feb 3, 2020
Ran the test 1000 times on TravisCI without issue.

Fix GoogleContainerTools#3537

Signed-off-by: David Gageot <[email protected]>
kissmikijr pushed a commit to kissmikijr/skaffold that referenced this pull request Feb 3, 2020
Ran the test 1000 times on TravisCI without issue.

Fix GoogleContainerTools#3537

Signed-off-by: David Gageot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants