Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake: TestGracefulBuildCancel #3537

Closed
balopat opened this issue Jan 20, 2020 · 2 comments
Closed

flake: TestGracefulBuildCancel #3537

balopat opened this issue Jan 20, 2020 · 2 comments
Labels
kind/bug Something isn't working meta/test-flake priority/p2 May take a couple of releases

Comments

@balopat
Copy link
Contributor

balopat commented Jan 20, 2020

Sometimes OSX travis tests fail with TestGracefulBuildCancel failures. We should eliminate these flakes.
@balopat balopat added meta/test-flake kind/bug Something isn't working priority/p2 May take a couple of releases labels Jan 20, 2020
@balopat
Copy link
Contributor Author

balopat commented Jan 27, 2020

Happened again,

/pkg/skaffold/build/misc/TestGracefulBuildCancel/terminate_gracefully_and_exit_0
    --- FAIL: TestGracefulBuildCancel/terminate_gracefully_and_exit_0 (0.24s)
        graceful_test.go:64: unexpected error: signal: killed
/pkg/skaffold/build/misc/TestGracefulBuildCancel
--- FAIL: TestGracefulBuildCancel (0.52s)

@balopat balopat mentioned this issue Jan 27, 2020
Merged
@dgageot
Copy link
Contributor

dgageot commented Jan 27, 2020

I've seen this test fail very often those days.

dgageot added a commit to dgageot/skaffold that referenced this issue Jan 29, 2020
@dgageot
Fix TestGracefulBuilCancel flake
991a7ee 
Ran the test 1000 times on TravisCI without issue.

Fix GoogleContainerTools#3537

Signed-off-by: David Gageot <[email protected]>
kissmikijr pushed a commit to kissmikijr/skaffold that referenced this issue Feb 3, 2020
@dgageot
Fix TestGracefulBuilCancel flake (GoogleContainerTools#3604)
05cf1cd 
Ran the test 1000 times on TravisCI without issue.

Fix GoogleContainerTools#3537

Signed-off-by: David Gageot <[email protected]>
kissmikijr pushed a commit to kissmikijr/skaffold that referenced this issue Feb 3, 2020
@dgageot
Fix TestGracefulBuilCancel flake (GoogleContainerTools#3604)
11bafe6 
Ran the test 1000 times on TravisCI without issue.

Fix GoogleContainerTools#3537

Signed-off-by: David Gageot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working meta/test-flake priority/p2 May take a couple of releases
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgageot @balopat