Add --target parameter with kaniko on Google Cloud Build #3462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwanjin-jeong
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
Codecov Report
|
dgageot
suggested changes
Dec 31, 2019
pkg/skaffold/build/gcb/kaniko.go
Outdated
| @@ -36,6 +36,7 @@ func (b *Builder) kanikoBuildSpec(artifact *latest.KanikoArtifact, tag string) ( | |||
| kanikoArgs := []string{ | |||
| "--destination", tag, | |||
| "--dockerfile", artifact.DockerfilePath, | |||
| "--target", artifact.Target, | |||
There was a problem hiding this comment.
Although it works well with an empty target, I'd rather add the --target only if the target is set. That feels better. You'd have to test both cases then.
There was a problem hiding this comment.
thanks for your advice.
dgageot
suggested changes
Dec 31, 2019
| "--build-arg", "arg1=value1", | ||
| "--build-arg", "arg2", | ||
| "--cache", | ||
| "--target", "builder", |
There was a problem hiding this comment.
Could you test for both cases?
There was a problem hiding this comment.
sorry, i late for refactoring.
do you have any suggestions?
dgageot
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#3399