Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaniko build on Google Cloud Build doesn't include --target parameter #3399

Closed
iamarcel opened this issue Dec 18, 2019 · 3 comments
Closed
Labels
area/build build/gcb build/kaniko good first issue Good for newcomers kind/bug Something isn't working priority/p2 May take a couple of releases

Comments

@iamarcel
Copy link

Expected behavior

When scheduling a Kaniko build on GCB, the artifact's Target parameter gets passed as an argument to the Kaniko executor on GCB, just like when building it in-cluster.

Actual behavior

The Kaniko build spec function doesn't include code to create a --target parameter (while the respective method for in-cluster builds does).

The tests for the GCB Kaniko build spec don't include the Target parameter either.

Information

  • Skaffold version: v1.0.1
  • Operating system: Fedora 31
  • Relevant contents of skaffold.yaml:
build:
  googleCloudBuild:
    projectId: my-google-project
  artifacts:
  - image: eu.gcr.io/my-google-project/build
    kaniko:
      target: build
      cache: {}
      buildContext:
        gcsBucket: my-kaniko-bucket

The GCB build details shows these arguments:

--destination eu.gcr.io/my-google-project/build:f4c58a6 --dockerfile Dockerfile --cache
@balopat balopat added build/gcb build/kaniko kind/bug Something isn't working platform/gcp priority/p2 May take a couple of releases good first issue Good for newcomers labels Dec 18, 2019
@balopat
Copy link
Contributor

balopat commented Dec 18, 2019

Thank you @iamarcel - I agree that this is missing, and you are pointing to the right places. PRs are welcome!

@hwanjin-jeong
Copy link
Contributor

I contribute to this issue
Please see that you want to check the resolved code: #3462

@dgageot
Copy link
Contributor

dgageot commented Jan 2, 2020

Fixed with #3462
Thanks a lot @hwanjin-jeong !

@dgageot dgageot closed this as completed Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build build/gcb build/kaniko good first issue Good for newcomers kind/bug Something isn't working priority/p2 May take a couple of releases
Projects
None yet
Development

No branches or pull requests

5 participants