Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker and go-containerregistry #3053

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Update docker and go-containerregistry #3053

merged 1 commit into from
Oct 14, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 14, 2019

This has to be merged after #3052

It might help with #1649

@codecov
Copy link

codecov bot commented Oct 14, 2019 •
edited
Loading

Codecov Report

Merging #3053 into master will decrease coverage by 0.04%.
The diff coverage is 27.27%.

Impacted Files Coverage Δ
pkg/skaffold/docker/auth.go 55.76% <27.27%> (-7.03%) ⬇️

@dgageot dgageot mentioned this pull request Oct 14, 2019
Closed
nkubala
nkubala approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i remember making these exact code changes when i tried to bump the deps a few months back 😆

@balopat
Copy link
Contributor

balopat commented Oct 14, 2019

#3052 is merged, please rebase.

@dgageot dgageot force-pushed the update-docker-ggcr branch from d1fd24b to 429fcef Compare October 14, 2019 19:31
@dgageot
Copy link
Contributor Author

dgageot commented Oct 14, 2019

@balopat done!

@dgageot dgageot merged commit ef120d6 into GoogleContainerTools:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@balopat balopat Awaiting requested review from balopat

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgageot @balopat @nkubala @googlebot