Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and rollback to older k8s #3052

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 14, 2019

At some point, we decided to vendor k8s 1.12.
When we switched to Go modules, we inadvertently switched to the latest version of k8s libraries (1.17.0-alpha.1)
We should at least rollback to 1.15 since it seems to be the oldest version that is go modules friendly

@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #3052 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/kubernetes/log.go 38.26% <ø> (ø) ⬆️
pkg/skaffold/kubernetes/status_check.go 76.19% <100%> (-1.59%) ⬇️

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😵

@balopat balopat merged commit 5cea007 into GoogleContainerTools:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants