Add Pod Status when pod is pending by going through pending container #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
requested review from
balopat,
dgageot,
nkubala and
priyawadhwa
as code owners
tejal29
force-pushed
the
add_pod_test
branch
from
02bfcaa to
466b842
Compare
Codecov Report
|
balopat
reviewed
Oct 4, 2019
| } | ||
|
|
||
| func GetPodDetails(client kubernetes.Interface, ns string, podName string) PodStatus { | ||
| pi := client.CoreV1().Pods(ns) |
There was a problem hiding this comment.
Suggested change
| pi := client.CoreV1().Pods(ns) | |
| pods := client.CoreV1().Pods(ns) |
balopat
suggested changes
Oct 4, 2019
balopat
changed the title
|
@balopat please take a look again! |
nkubala
reviewed
Oct 7, 2019
| default: | ||
| reason, detail := getWaitingContainerStatus(pod.Status.ContainerStatuses) | ||
| return newPendingStatus(reason, detail) | ||
|
|
| } | ||
|
|
||
| func (e *PodErr) Error() string { | ||
| return fmt.Sprintf("pod in error due to reason: %s, message: %s", e.reason, e.message) |
There was a problem hiding this comment.
this error message is a bit confusing to me. what is the reason vs the message? like shouldn't the message implicitly have the reason that the pod is failing?
There was a problem hiding this comment.
Reason is the error code and message is Message explaining Reason.
There was a problem hiding this comment.
an example would be "Reasan: ErrImgPull", Message: "image:tag could not be fetched"
Just Reason is not enough.
balopat
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #176
Add Pod Status when pod is pending by going through pending container.
Description
User facing changes
n/a
Next PRs.
Use this #2928
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes