Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod resource with no status check implemented. #2928

Merged
merged 8 commits into from
Sep 24, 2019

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Sep 23, 2019

Relates to #176

Description

User facing changes

Write n/a if not output or log lines changed and no behavior is changed

Before

If log/output changes: Paste the current relevant skaffold output
If behavior changes: describe succinctly the current behavior

After

If log/output changes: Paste skaffold output after your change
If behavior changes: describe succintly the behavior after your change

Next PRs.

In this section describe a list of follow up PRs if the current PR is a part of big feature change.

See example #2811

Write n/a if not applicable.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [X ] Includes unit tests
  • [ X] Mentions any output changes.
  • [ n/a] Adds documentation as needed: user docs, YAML reference, CLI reference.
  • [ n/a] Adds integration tests if needed.

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

Describe any user facing changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- Skaffold config changes like
  e.g. "Add buildArgs to `Kustomize` deployer skaffold config."
- Bug fixes
  e.g. "Improve skaffold init behaviour when tags are used in manifests"
- Any changes in skaffold behavior
  e.g. "Artiface cachine is turned on by default."

@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #2928 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/deploy/resource/pod.go 100% <100%> (ø)

Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one nit

pkg/skaffold/deploy/resource/pod.go Show resolved Hide resolved
@tejal29 tejal29 merged commit c23ce33 into GoogleContainerTools:master Sep 24, 2019
@tejal29 tejal29 deleted the add_pod_new branch May 19, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants