Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design proposal for integrationtest command #2671

Merged
merged 2 commits into from
Sep 6, 2019
Merged

Design proposal for integrationtest command #2671

merged 2 commits into from
Sep 6, 2019

Conversation

daddz
Copy link
Contributor

@daddz daddz commented Aug 16, 2019

Related PR: #2594
Related issues: #2561, #992

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #2671 into master will increase coverage by 1.53%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/gcp/auth.go 37.83% <0%> (-62.17%) ⬇️
...kg/skaffold/generate_pipeline/generate_pipeline.go 40.25% <0%> (-14.09%) ⬇️
pkg/skaffold/build/cache/retrieve.go 63.29% <0%> (-4.28%) ⬇️
pkg/skaffold/build/gcb/types.go 14.7% <0%> (-3.16%) ⬇️
pkg/skaffold/util/tar.go 43.61% <0%> (-2.82%) ⬇️
pkg/skaffold/initializer/init.go 59.14% <0%> (-2.15%) ⬇️
pkg/skaffold/docker/remote.go 14% <0%> (-1.69%) ⬇️
pkg/skaffold/build/cache/hash.go 60% <0%> (-1.3%) ⬇️
pkg/skaffold/runner/build_deploy.go 67.14% <0%> (-1.12%) ⬇️
pkg/skaffold/deploy/labels.go 15.85% <0%> (-1.03%) ⬇️
... and 70 more

@nkubala
Copy link
Contributor

nkubala commented Aug 20, 2019

hey @daddz, thanks for writing this up! we really appreciate your interest in this and the effort you went through to draft this up, but we've decided that at the moment this isn't a direction we want to go with skaffold - see my comment on your related issue for a bit more explanation. apologies for having to send this one back, but thanks for being so enthusiastic about building new features in skaffold!

@nkubala nkubala closed this Aug 20, 2019
@tejal29 tejal29 reopened this Sep 6, 2019
@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Sep 6, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Sep 6, 2019
Copy link
Member

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added reason for cancellation.

@tejal29 tejal29 merged commit d907dfc into GoogleContainerTools:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants