Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test command #2594

Closed
wants to merge 10 commits into from
Closed

Integration test command #2594

wants to merge 10 commits into from

Conversation

daddz
Copy link
Contributor

@daddz daddz commented Aug 1, 2019

I have put some more work into this as mentioned in #2561.

For demonstration purposes I created another repository that makes use of these changes over here: https://github.com/daddz/skaffold-integration

When running the integrationtest command it will try to find the first pod that matches the defined podSelector and then executes the specified testCommand via kubectl exec in that pod.

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #2594 into master will decrease coverage by 0.15%.
The diff coverage is 45.61%.

Impacted Files Coverage Δ
pkg/skaffold/schema/versions.go 74.35% <ø> (ø) ⬆️
pkg/skaffold/runner/runner.go 0% <ø> (ø) ⬆️
pkg/skaffold/schema/v1beta12/upgrade.go 100% <ø> (ø) ⬆️
pkg/skaffold/schema/latest/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/runner/build_deploy.go 64.17% <0%> (-4.08%) ⬇️
pkg/skaffold/integrationtest/integrationtest.go 0% <0%> (ø)
pkg/skaffold/schema/v1beta13/config.go 100% <100%> (ø)
pkg/skaffold/schema/defaults/defaults.go 90.66% <100%> (+0.25%) ⬆️
cmd/skaffold/app/cmd/cmd.go 68.5% <100%> (+0.24%) ⬆️
pkg/skaffold/schema/v1beta13/upgrade.go 100% <100%> (ø)
... and 6 more

Copy link
Member

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daddz Thank you for your contribution.
You are adding a new Command to skaffold and we now have a process to add new features.
Its is documented here https://github.com/GoogleContainerTools/skaffold/tree/master/docs/design_proposals

Can you please add a DD for this feature? Please feel free to add me as a Design Shepherd.

pkg/skaffold/integrationtest/integrationtest.go Outdated Show resolved Hide resolved
pkg/skaffold/integrationtest/integrationtest.go Outdated Show resolved Hide resolved
pkg/skaffold/integrationtest/integrationtest.go Outdated Show resolved Hide resolved
pkg/skaffold/runner/build_deploy.go Outdated Show resolved Hide resolved
pkg/skaffold/integrationtest/integrationtest.go Outdated Show resolved Hide resolved
pkg/skaffold/integrationtest/integrationtest.go Outdated Show resolved Hide resolved
@daddz
Copy link
Contributor Author

daddz commented Aug 16, 2019

@tejal29 thanks for the feedback!
I addressed your comments and created a design proposal: #2671

@daddz daddz closed this Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants