Go Modules

[dgageot]

No description provided.

[codecov]

Codecov Report

Merging #2541 into master will increase coverage by 0.02%.
The diff coverage is 33.33%.

Impacted Files	Coverage Δ
pkg/skaffold/build/gcb/cloud_build.go	0% <0%> (ø)	⬆️
pkg/skaffold/deploy/labels.go	16.04% <0%> (ø)	⬆️
pkg/skaffold/kubernetes/watcher.go	100% <100%> (ø)	⬆️
pkg/skaffold/kubernetes/wait.go	45.83% <50%> (-0.22%)	⬇️

[nkubala]

just tested the release build locally and it works for me, so looks like setting GOMODULE11=on in the makefile was enough to solve the xgo issue. @dgageot what more do you think needs to be done here?

[dgageot]

@nkubala I think we're good. I was wondering if we should vendor dependencies or re-download them on each build. I think vendoring is faster. Let me remove the [WIP] prefix!

[nkubala]

I'm not 100% sure but I think if we're keeping the vendored deps then we want to pass -mod=vendor to go build? otherwise won't it fetch the deps from go.mod and use those to build instead?

[dgageot]

@nkubala TIL. It's fixed now

[nkubala]

cool. and because of this we don't need to worry about downloading from a proxy right?

[dgageot]

Yes Le lun. 29 juil. 2019 à 21:50, Nick Kubala <[email protected]> a écrit :

…

cool. and because of this we don't need to worry about downloading from a proxy right? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2541?email_source=notifications&email_token=AABFPF4GJS7NX5NETFZ5PUDQB5CZ7A5CNFSM4IGSTZHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3B2BQY#issuecomment-516137155>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABFPF2QD7FHLTXFY5JXOITQB5CZ7ANCNFSM4IGSTZHA> .

[nkubala]

lets give it a shot

[nkubala]

0.09s$ go build -mod=vendor -o out/skaffold.exe cmd/skaffold/skaffold.go
The command "go build -mod=vendor -o out/skaffold.exe cmd/skaffold/skaffold.go" exited with 1.

390.10s$ go test -short -timeout 60s ./...
build flag -mod=vendor only valid when using modules

not sure why this is happening, or why it only happened with the windows build...

looks like the windows build is broken, let's figure that out

[nkubala]

everything is green! @dgageot merge when you're ready