Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using go modules #2451

Closed
nkubala opened this issue Jul 11, 2019 · 5 comments
Closed

Switch to using go modules #2451

nkubala opened this issue Jul 11, 2019 · 5 comments
Labels
internal kind/todo implementation task/epic for the skaffold team meta/release

Comments

@nkubala
Copy link
Contributor

nkubala commented Jul 11, 2019

Go modules are nicer than dep for handling dependency management. We should switch skaffold over to use them.
@nkubala nkubala mentioned this issue Jul 11, 2019
Merged
@dgageot
Copy link
Contributor

dgageot commented Jul 12, 2019

@nkubala are you working on it or can I take the action?

@nkubala
Copy link
Contributor Author

nkubala commented Jul 12, 2019

@dgageot I haven't started on it yet, if you wanna take it on go for it

@dgageot dgageot assigned dgageot and unassigned dgageot Jul 15, 2019
@dgageot
Copy link
Contributor

dgageot commented Jul 16, 2019

@nkubala I tried a bit and failed! I've unassigned myself.

@SantoshSah
Copy link

SantoshSah commented Jul 18, 2019 •
edited
Loading

Any work around for using Skaffold in Go Module project till you natively support it? How can we ignore some files(go.mod and go.sum) to be watched by Skaffold?

@nkubala nkubala mentioned this issue Jul 23, 2019
Closed
@nkubala
Copy link
Contributor Author

nkubala commented Jul 30, 2019

closed with #2541

@nkubala nkubala closed this as completed Jul 30, 2019
@balopat balopat added the kind/todo implementation task/epic for the skaffold team label Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal kind/todo implementation task/epic for the skaffold team meta/release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

switch to go modules nkubala/skaffold
4 participants
@dgageot @balopat @SantoshSah @nkubala