Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kaniko proxy #2283

Merged
merged 19 commits into from
Jul 10, 2019
Merged

Kaniko proxy #2283

merged 19 commits into from
Jul 10, 2019

Conversation

prary
Copy link
Contributor

@prary prary commented Jun 18, 2019

Implementation of PR #2064 Setting proxy for Kaniko Pod

balopat
balopat previously requested changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this!
Do you mind adding a test?
After a test + fixing travis this LGTM.

@prary
Copy link
Contributor Author

prary commented Jun 20, 2019

@balopat fixed travis error.

@codecov
Copy link

codecov bot commented Jun 20, 2019 •
edited
Loading

Codecov Report

Merging #2283 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/build/cluster/sources/sources.go 92.15% <100%> (+1.24%) ⬆️

tejal29
tejal29 suggested changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests

@balopat balopat added docs-modifications runs the docs preview service on the given PR and removed meta/docs-preview labels Jun 21, 2019
@container-tools-bot
Copy link

Please visit http://35.236.79.231:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Jun 21, 2019
@priyawadhwa
Copy link
Contributor

Hey @prary , please run make generate-schemas and commit the results for Travis to pass!

@tejal29 tejal29 mentioned this pull request Jul 9, 2019
Merged
@tejal29 tejal29 added the docs-modifications runs the docs preview service on the given PR label Jul 9, 2019
@container-tools-bot
Copy link

Please visit http://35.235.66.89:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Jul 9, 2019
@tejal29 tejal29 force-pushed the kaniko_proxy branch 2 times, most recently from 27cf723 to f26274b Compare July 10, 2019 04:17
@tejal29 tejal29 added the kokoro:run runs the kokoro jobs on a PR label Jul 10, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jul 10, 2019
@tejal29 tejal29 merged commit befbe09 into GoogleContainerTools:master Jul 10, 2019
@prary prary mentioned this pull request Jul 24, 2019
Closed
@prary prary deleted the kaniko_proxy branch July 26, 2019 14:29
@asifdxtreme asifdxtreme mentioned this pull request Aug 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat balopat left review comments

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
cla: yes !! config-change !!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@prary @container-tools-bot @priyawadhwa @balopat @tejal29 @googlebot @kokoro-team