[Design Proposal] Setting proxy for Kaniko Pod #2064
Conversation
prary
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
tejal29
as code owners
Co-Authored-By: prary <[email protected]>
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #2064 +/- ##
=========================================
+ Coverage 56.06% 56.26% +0.2%
=========================================
Files 179 180 +1
Lines 7745 7800 +55
=========================================
+ Hits 4342 4389 +47
- Misses 2987 2994 +7
- Partials 416 417 +1
Continue to review full report at Codecov.
|
prary
changed the title
| http_proxy string `yaml:"http_proxy,omitempty"` | ||
|
|
||
| // https_proxy | ||
| https_proxy string `yaml:"http_proxys,omitempty"` |
There was a problem hiding this comment.
hi @prary, are https_proxy and http_proxys the new config values?
There was a problem hiding this comment.
Adding these 2 fields is not a big issue. I think the team is ok with it!
Would you be able to submit a PR?
There was a problem hiding this comment.
Yes I will make the changes and raise a PR for the same
There was a problem hiding this comment.
Is there any deadline to raise PR?
| http_proxy string `yaml:"http_proxy,omitempty"` | ||
|
|
||
| // https_proxy | ||
| https_proxy string `yaml:"http_proxys,omitempty"` |
There was a problem hiding this comment.
Adding these 2 fields is not a big issue. I think the team is ok with it!
Would you be able to submit a PR?
|
No there is no such deadline! |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
HTTP/HTTPs Proxy for kaniko pod while running in labs.