Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade golangci-lint to v1.17.1 #2248

Merged
merged 3 commits into from
Jun 13, 2019
Merged

Upgrade golangci-lint to v1.17.1 #2248

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e69cb3
Upgrade golangci-lint to v1.17.1
corneliusweig Jun 10, 2019
a4648e8
Re-run hack/generate-man.sh
corneliusweig Jun 10, 2019
97fc27e
Merge remote-tracking branch 'origin/master' into upgrade-linter
corneliusweig Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/skaffold/app/cmd/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func NewCmdBuild(out io.Writer) *cobra.Command {
WithFlags(func(f *pflag.FlagSet) {
f.StringSliceVarP(&opts.TargetImages, "build-image", "b", nil, "Choose which artifacts to build. Artifacts with image names that contain the expression will be built only. Default is to build sources for all artifacts")
f.BoolVarP(&quietFlag, "quiet", "q", false, "Suppress the build output and print image built on success. See --output to format output.")
f.VarP(buildFormatFlag, "output", "o", "Used in conjuction with --quiet flag. "+buildFormatFlag.Usage())
f.VarP(buildFormatFlag, "output", "o", "Used in conjunction with --quiet flag. "+buildFormatFlag.Usage())
}).
NoArgs(cancelWithCtrlC(context.Background(), doBuild))
}
Expand Down
2 changes: 1 addition & 1 deletion docs/content/en/docs/references/cli/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ Flags:
-f, --filename string Filename or URL to the pipeline file (default "skaffold.yaml")
--insecure-registry strings Target registries for built images which are not secure
-n, --namespace string Run deployments in the specified namespace
-o, --output *flags.TemplateFlag Used in conjuction with --quiet flag. Format output with go-template. For full struct documentation, see https://godoc.org/github.com/GoogleContainerTools/skaffold/cmd/skaffold/app/flags#BuildOutput (default {{json .}})
-o, --output *flags.TemplateFlag Used in conjunction with --quiet flag. Format output with go-template. For full struct documentation, see https://godoc.org/github.com/GoogleContainerTools/skaffold/cmd/skaffold/app/flags#BuildOutput (default {{json .}})
-p, --profile strings Activate profiles by name
-q, --quiet Suppress the build output and print image built on success. See --output to format output.
--rpc-http-port int tcp port to expose event REST API over HTTP (default 50052)
Expand Down
2 changes: 1 addition & 1 deletion hack/linter.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

if ! [ -x "$(command -v golangci-lint)" ]; then
echo "Installing GolangCI-Lint"
${DIR}/install_golint.sh -b $GOPATH/bin v1.16.0
${DIR}/install_golint.sh -b $GOPATH/bin v1.17.1
fi

golangci-lint run \
Expand Down
2 changes: 1 addition & 1 deletion pkg/skaffold/build/local/local_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ func TestLocalRun(t *testing.T) {
shouldErr: true,
},
{
description: "unkown artifact type",
description: "unknown artifact type",
artifacts: []*latest.Artifact{{}},
shouldErr: true,
},
Expand Down