Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci-lint to v1.17.1 #2248

Merged
merged 3 commits into from
Jun 13, 2019

Conversation

corneliusweig
Copy link
Contributor

And fix new reported issues

And fix new reported issues

Signed-off-by: Cornelius Weig <[email protected]>
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, can you run ./hack/check-docs.sh

@corneliusweig
Copy link
Contributor Author

@nkubala Whoops sorry. Should have thought about that.

I think the travis run has hit some data-race which has nothing to do with these changes.

@balopat
Copy link
Contributor

balopat commented Jun 11, 2019

yupp, this fixes it: #2251
The problem was at

....
			for _, phase := range test.phases {
				if fakeWatcher.IsStopped() {
					break
				}

                                /// at this point fakeWatcher could stop and 
                               /// Modify then tried to send a message to a closed channel

				fakeWatcher.Modify(&v1.Pod{
					Status: v1.PodStatus{
						Phase: phase,
					},
				})
				time.Sleep(time.Second)
			}
....				

@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Jun 11, 2019
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jun 11, 2019
@corneliusweig
Copy link
Contributor Author

I merged master to get a clean travis build.

@dgageot dgageot dismissed nkubala’s stale review June 13, 2019 12:46

Doc was updated

@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Jun 13, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jun 13, 2019
@balopat balopat merged commit 0a03dd7 into GoogleContainerTools:master Jun 13, 2019
@corneliusweig corneliusweig deleted the upgrade-linter branch June 13, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants