-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade golangci-lint to v1.17.1 #2248
Upgrade golangci-lint to v1.17.1 #2248
Conversation
And fix new reported issues Signed-off-by: Cornelius Weig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, can you run ./hack/check-docs.sh
@nkubala Whoops sorry. Should have thought about that. I think the travis run has hit some data-race which has nothing to do with these changes. |
yupp, this fixes it: #2251 ....
for _, phase := range test.phases {
if fakeWatcher.IsStopped() {
break
}
/// at this point fakeWatcher could stop and
/// Modify then tried to send a message to a closed channel
fakeWatcher.Modify(&v1.Pod{
Status: v1.PodStatus{
Phase: phase,
},
})
time.Sleep(time.Second)
}
.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
I merged master to get a clean travis build. |
And fix new reported issues