Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor doc updates #1923

Merged
merged 5 commits into from
Apr 4, 2019
Merged

Minor doc updates #1923

merged 5 commits into from
Apr 4, 2019

Conversation

chanseokoh
Copy link
Member

No description provided.

@chanseokoh
Copy link
Member Author

Test is broken due to #1924.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

nkubala
nkubala previously requested changes Apr 4, 2019
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the motivation for this? I'm not necessarily opposed just want to understand.

also, if we're doing this then let's remove 1.11 from the travis.yml.

@balopat
Copy link
Contributor

balopat commented Apr 4, 2019

Thanks for asking the right question @nkubala, I was too fast to approve.
Actually it is not true either - our release and integration tests are also based on go 1.11 - so we should change that first deploy/skaffold/Dockerfile

@chanseokoh chanseokoh changed the title Require go >= 1.12 Minor doc updates Apr 4, 2019
@chanseokoh
Copy link
Member Author

Perhaps my go installation had some problem, which made me to think upgrading to 1.12 resolved the issue. I reverted the 1.1.2 requirement.

@chanseokoh
Copy link
Member Author

I merged with master, and tests should pass.

@codecov-io
Copy link

Codecov Report

Merging #1923 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1923   +/-   ##
=======================================
  Coverage   52.07%   52.07%           
=======================================
  Files         179      179           
  Lines        7923     7923           
=======================================
  Hits         4126     4126           
  Misses       3415     3415           
  Partials      382      382

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 285c1df...1075b51. Read the comment docs.

@balopat balopat merged commit 533378c into GoogleContainerTools:master Apr 4, 2019
@chanseokoh chanseokoh deleted the patch-2 branch April 9, 2019 04:06
@tejal29 tejal29 mentioned this pull request Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants