-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor doc updates #1923
Minor doc updates #1923
Conversation
Test is broken due to #1924. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the motivation for this? I'm not necessarily opposed just want to understand.
also, if we're doing this then let's remove 1.11
from the travis.yml
.
Thanks for asking the right question @nkubala, I was too fast to approve. |
Perhaps my go installation had some problem, which made me to think upgrading to 1.12 resolved the issue. I reverted the 1.1.2 requirement. |
I merged with master, and tests should pass. |
Codecov Report
@@ Coverage Diff @@
## master #1923 +/- ##
=======================================
Coverage 52.07% 52.07%
=======================================
Files 179 179
Lines 7923 7923
=======================================
Hits 4126 4126
Misses 3415 3415
Partials 382 382 Continue to review full report at Codecov.
|
No description provided.