Test broken (./test.sh)

[chanseokoh]

chanseok@chanseok1:~/go/src/github.com/GoogleContainerTools/skaffold (master)$ git fetch upstream
chanseok@chanseok1:~/go/src/github.com/GoogleContainerTools/skaffold (master)$ git merge upstream/master
Already up to date.
chanseok@chanseok1:~/go/src/github.com/GoogleContainerTools/skaffold (master)$ git pull
Already up to date.
chanseok@chanseok1:~/go/src/github.com/GoogleContainerTools/skaffold (master)$ make test
Running go tests...
ok      github.com/GoogleContainerTools/skaffold/cmd/skaffold/app       0.939s  coverage: 2.9% of statements in ./pkg/..., ./cmd/...
ok      github.com/GoogleContainerTools/skaffold/cmd/skaffold/app/cmd   1.207s  coverage: 4.9% of statements in ./pkg/..., ./cmd/...
ok      github.com/GoogleContainerTools/skaffold/cmd/skaffold/app/cmd/config    1.647s  coverage: 1.6% of statements in ./pkg/..., ./cmd/...
ok      github.com/GoogleContainerTools/skaffold/cmd/skaffold/app/flags 0.852s  coverage: 0.6% of statements in ./pkg/..., ./cmd/...
ok      github.com/GoogleContainerTools/skaffold/cmd/skaffold/man       1.432s  coverage: 2.7% of statements in ./pkg/..., ./cmd/...
--- FAIL: TestSchemas (1.13s)
    main_test.go:37: json schema files are not up to date. Please run `make generate-schemas` and commit the changes.
FAIL
coverage: 0.4% of statements in ./pkg/..., ./cmd/...
FAIL    github.com/GoogleContainerTools/skaffold/hack/schemas   2.457s
^C/usr/lib/google-golang/pkg/tool/linux_amd64/link: signal: interrupt
/usr/lib/google-golang/pkg/tool/linux_amd64/link: signal: interrupt
/usr/lib/google-golang/pkg/tool/linux_amd64/link: signal: interrupt
/usr/lib/google-golang/pkg/tool/linux_amd64/link: signal: interrupt
/usr/lib/google-golang/pkg/tool/linux_amd64/link: signal: interrupt
Makefile:80: recipe for target 'test' failed
make: *** [test] Error 130

Running make generate-schemas generates docs/content/en/schemas/v1beta8.json:

chanseok@chanseok1:~/go/src/github.com/GoogleContainerTools/skaffold (master)$ make generate-schemas
go run hack/schemas/main.go
chanseok@chanseok1:~/go/src/github.com/GoogleContainerTools/skaffold (master)$ 

With the generated file, make test runs OK. I see this file has been removed in past commits. Should this be revived?

[balopat]

can you rebase to the latest master?

This looks like a merge error to me that was fixed with #1922.

[chanseokoh]

Resolved after merging. Thanks!