Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix port-forwarding not being triggered. #1433

Merged
merged 1 commit into from
Dec 31, 2018
+10 −4
Merged

Fix port-forwarding not being triggered. #1433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions pkg/skaffold/kubernetes/port_forward.go
View file
Original file line number Diff line number Diff line change
@@ -141,16 +141,22 @@ func (p *PortForwarder) Start(ctx context.Context) error {
return
}

// Pods will never be "added" in a state that they are ready for port-forwarding
// so only watch "modified" events
if evt.Type != watch.Modified {
// If the event's type is "ERROR", warn and continue.
if evt.Type == watch.Error {
logrus.Warnf("got unexpected event of type %s", evt.Type)
continue
}

// Grab the pod from the event.
pod, ok := evt.Object.(*v1.Pod)
if !ok {
continue
}
// If the event's type is "DELETED", warn and continue.
if evt.Type == watch.Deleted {
logrus.Warnf("got unexpected event of type %s for pod %s/%s", evt.Type, pod.Namespace, pod.Name)
}
// At this point, we know the event's type if "ADDED" or "MODIFIED".
// We must take both types into account as it is possible for the pod to have become ready for port-forwarding before we established the watch.
if p.podSelector.Select(pod) && pod.Status.Phase == v1.PodRunning && pod.DeletionTimestamp == nil {
go func() {
if err := p.portForwardPod(pod); err != nil {