Fix port-forwarding not being triggered. #1433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running
skaffold dev
to deploy a pod containing some port definitions, I noticed that port-forwardings were not being triggered. Turns out this was happening because...ADDED
events are currently ignored by the port forwarder's pod watcher; andRunning
phase when the watcher is established; andMODIFIED
) were received for that pod (so as to trigger forwarding).My proposal is that the port forwarder's pod watcher starts taking
ADDED
events into account.