-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically fix old configs by default #1259
Conversation
…latest semver to package level function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change I would like to cover all the upgrades with unit tests and hunt down if there are any issues.
Codecov Report
@@ Coverage Diff @@
## master #1259 +/- ##
==========================================
+ Coverage 42.42% 44.19% +1.76%
==========================================
Files 96 104 +8
Lines 4247 4614 +367
==========================================
+ Hits 1802 2039 +237
- Misses 2269 2366 +97
- Partials 176 209 +33
Continue to review full report at Codecov.
|
Added unit tests for all config upgrades
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
This adds a hook in the runner to automatically try and upgrade older configs to the latest version before running skaffold. This means users with older configs will no longer be required to run
skaffold fix
to run skaffold as we upgrade the config.I'll leave
skaffold fix
in, in case anybody wants to use it to upgrade their config and overwrite it in their repo.Fixes #1257