Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support old config versions automatically besides skaffold fix #1257

Closed
balopat opened this issue Nov 8, 2018 · 2 comments · Fixed by #1259
Closed

Support old config versions automatically besides skaffold fix #1257

balopat opened this issue Nov 8, 2018 · 2 comments · Fixed by #1259
Labels
kind/feature-request priority/p0 Highest priority. We are actively looking at delivering it.
Milestone
v1beta1 skaffold....

Comments

@balopat
Copy link
Contributor

balopat commented Nov 8, 2018

Currently old versions can be upgraded with skaffold fix. Besides 'fixing' Skaffold should support older config versions automatically and just print out a warning message.
@balopat balopat added kind/feature-request priority/p0 Highest priority. We are actively looking at delivering it. labels Nov 8, 2018
@balopat balopat added this to the Skaffold Beta milestone Nov 8, 2018
@nkubala nkubala mentioned this issue Nov 8, 2018
Merged
@dlorenc
Copy link
Contributor

dlorenc commented Nov 9, 2018

Is this in addition to the fix command, or instead of? It might make sense to keep both.

@nkubala
Copy link
Contributor

nkubala commented Nov 9, 2018

In addition to. We'll leave the fix command around in case users want to permanently update their configs.

@balopat balopat changed the title Support old config versions automatically instead of skaffold fix Support old config versions automatically besides skaffold fix Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature-request priority/p0 Highest priority. We are actively looking at delivering it.
Projects
None yet
Milestone
v1beta1 skaffold.yaml
Development

Successfully merging a pull request may close this issue.

Automatically fix old configs by default nkubala/skaffold
3 participants
@balopat @dlorenc @nkubala