Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change jib.dockerDir to jib.targetDir in maven plugin for consistency #663

Merged
merged 5 commits into from
Jul 19, 2018
Merged

Change jib.dockerDir to jib.targetDir in maven plugin for consistency #663

merged 5 commits into from
Jul 19, 2018

Conversation

TadCordle
Copy link
Contributor

Fix #662

briandealwis
briandealwis reviewed Jul 19, 2018
View reviewed changes
Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some other references in the README.mds

@TadCordle
Copy link
Contributor Author

TadCordle commented Jul 19, 2018 •
edited
Loading

@briandealwis I'm working on the README changes in another PR; we probably shouldn't merge them until after the next version is released.

Edit: not ready for review yet, but I've updated them here: #664

@TadCordle TadCordle merged commit 05aa0da into master Jul 19, 2018
@TadCordle TadCordle deleted the rename-jib-dockerDir branch July 19, 2018 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis left review comments

@coollog coollog coollog approved these changes

@chanseokoh chanseokoh Awaiting requested review from chanseokoh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TadCordle @briandealwis @coollog