Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "-Djib.dockerDir" in maven plugin for consistency #662

Closed
TadCordle opened this issue Jul 19, 2018 · 4 comments
Closed

Change "-Djib.dockerDir" in maven plugin for consistency #662

TadCordle opened this issue Jul 19, 2018 · 4 comments
Assignees
Milestone

Comments

@TadCordle
Copy link
Contributor

TadCordle commented Jul 19, 2018

In gradle, the configuration option is targetDir, and the parameter is --targetDir.

In maven, the configuration option is targetDir, and the parameter is -Djib.dockerDir. We should make it more consistent (something like -Djib.targetDir, or maybe even just -DtargetDir).

@TadCordle TadCordle changed the title Change "-Djib.dockerDir" to "-Djib.targetDir" in maven plugin Change "-Djib.dockerDir" in maven plugin for consistency Jul 19, 2018
@chanseokoh
Copy link
Member

Personally I vote for jib.targetDir. -DtargetDir sounds too general that may easily conflict with others.

@TadCordle TadCordle self-assigned this Jul 19, 2018
@TadCordle TadCordle modified the milestones: v0.9.8, v0.9.7 Jul 19, 2018
@coollog
Copy link
Contributor

coollog commented Jul 19, 2018

I believe the issue with Gradle is that it doesn't allow for . in the property name. It might have to be jibTargetDir

@TadCordle
Copy link
Contributor Author

TadCordle commented Jul 19, 2018

Change it to jibTargetDir for both?

@coollog
Copy link
Contributor

coollog commented Jul 19, 2018

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants