-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change base image cache location on mac/windows, add methods for getting XDG config location #2218
Conversation
If we have to do this, should we also change the Linux directory to be consistent, from |
Consistency would certainly make this easier. I don't really care where it ends up either way personally. That said, it sounds like there are some conventions people like to follow on different platforms (see #2211 (review)) |
Ah, okay. Forget changing |
Fixes #2216.
Adds methods for retrieving the config directory:
$HOME/.config/google-cloud-tools-java/jib/
$HOME/Library/Preferences/Google/Jib/
%LOCALAPPDATA%\Google\Jib\Config
Also changes the cache directory on Mac/Windows to the following:
Before:
$HOME/Library/Application Support/google-cloud-tools-java/jib/
%LOCALAPPDATA/google-cloud-tools-java/jib/
After:
$HOME/Library/Caches/Google/Jib/
%LOCALAPPDATA\Google\Jib\Cache\
Linux is still at
$HOME/.cache/google-cloud-tools-java/jib/
. Will need to update documentation to help users migrate the old cache over to the new location.