Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cache location on Mac/Windows #2216

Closed
2 tasks done
TadCordle opened this issue Jan 7, 2020 · 5 comments · Fixed by #2218 or #2231
Closed
2 tasks done

Change cache location on Mac/Windows #2216

TadCordle opened this issue Jan 7, 2020 · 5 comments · Fixed by #2218 or #2231
Milestone

Comments

@TadCordle
Copy link
Contributor

TadCordle commented Jan 7, 2020

Currently, the base image cache is located at:

  • Mac: $HOME/Library/Application Support/google-cloud-tools-java/jib/
  • Win: %LOCALAPPDATA/google-cloud-tools-java/jib/

It may be a good idea to change these to:

  • Mac: $HOME/Library/Caches/Google/Jib/
  • Win: %LOCALAPPDATA/Google/Jib/Cache/

We may need to come up with a migration strategy so we don't break users who rely heavily on the cache (e.g. offline users).

Checklist:

@briandealwis
Copy link
Member

The Win cache should be in %LOCALAPPDATA%/Google/Jib/Cache just to be clear that it can be removed without affecting other possible configuration files.

@chanseokoh
Copy link
Member

We may need to come up with a migration strategy so we don't break users who rely heavily on the cache (e.g. offline users).

I'm leaning toward documentation rather than adding code to do automatic migration for a number of reasons.

@TadCordle
Copy link
Contributor Author

TadCordle commented Jan 9, 2020

Gonna keep this open until the documentation is updated

@TadCordle TadCordle reopened this Jan 9, 2020
@chanseokoh
Copy link
Member

Alos, does it make sense to update CHANGELOG to describe the changes to the base image cache directory on some platforms by #2218?

@TadCordle
Copy link
Contributor Author

Oh right, was gonna do that but forgot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants