Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SOA Deletion short-circuit #2212

Conversation

modular-magician
Copy link
Collaborator

Added short-circuit deletion for SOA-Records on the root-zone with corresponding tests and documentation. A new PR since GoogleCloudPlatform/magic-modules#6724 was stale.

Fixes hashicorp/terraform-provider-google#12827

Release Note Template for Downstream PRs (will be copied)

dns: fixed bug where the deletion of manages zones that have a SOA-Record set with terraform did not work

Derived from GoogleCloudPlatform/magic-modules#10559

[upstream:9efe66970062aec5a16e3aef55cc523bd699ae56]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner April 30, 2024 13:59
@modular-magician modular-magician requested review from iyabchen and removed request for a team April 30, 2024 13:59
@modular-magician modular-magician merged commit 794b00e into GoogleCloudPlatform:main Apr 30, 2024
1 check passed
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician deleted the downstream-pr-9efe66970062aec5a16e3aef55cc523bd699ae56 branch November 18, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deletion of managed SOA record-sets fails on terraform destroy
1 participant