-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SOA Deletion short-circuit #10559
Adding SOA Deletion short-circuit #10559
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Thanks for your PR! I'm going to trigger the acceptance tests to run & see how they fair. In the meantime please take a look at the guidance about release notes : https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/#type-specific-guidelines-and-examples |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDNSRecordSet_deletionSOA |
Hi, I updated the description accordingly :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the release note!
I can see the updated debug log entry is made when TestAccDNSRecordSet_deletionSOA
runs, and the managed zone is able to be deleted in the test's cleanup step. Merging
Added short-circuit deletion for SOA-Records on the root-zone with corresponding tests and documentation. A new PR since #6724 was stale.
Fixes hashicorp/terraform-provider-google#12827
Release Note Template for Downstream PRs (will be copied)