Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SOA Deletion short-circuit #10559

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Adding SOA Deletion short-circuit #10559

merged 2 commits into from
Apr 30, 2024

Conversation

NiklasDah
Copy link
Contributor

@NiklasDah NiklasDah commented Apr 30, 2024

Added short-circuit deletion for SOA-Records on the root-zone with corresponding tests and documentation. A new PR since #6724 was stale.

Fixes hashicorp/terraform-provider-google#12827

Release Note Template for Downstream PRs (will be copied)

dns: fixed bug where the deletion of manages zones that have a SOA-Record set with terraform did not work

@github-actions github-actions bot requested a review from SarahFrench April 30, 2024 08:16
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Apr 30, 2024
@SarahFrench
Copy link
Contributor

Thanks for your PR! I'm going to trigger the acceptance tests to run & see how they fair. In the meantime please take a look at the guidance about release notes : https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/#type-specific-guidelines-and-examples

@modular-magician modular-magician added service/cloud-dns and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Apr 30, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 51 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 51 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 47
Passed tests: 45
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • dns

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDNSRecordSet_deletionSOA

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDNSRecordSet_deletionSOA[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@NiklasDah
Copy link
Contributor Author

Thanks for your PR! I'm going to trigger the acceptance tests to run & see how they fair. In the meantime please take a look at the guidance about release notes : https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/#type-specific-guidelines-and-examples

Hi, I updated the description accordingly :)

Copy link
Contributor

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the release note!

I can see the updated debug log entry is made when TestAccDNSRecordSet_deletionSOA runs, and the managed zone is able to be deleted in the test's cleanup step. Merging :shipit:

@SarahFrench SarahFrench merged commit 9efe669 into GoogleCloudPlatform:main Apr 30, 2024
12 of 14 checks passed
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deletion of managed SOA record-sets fails on terraform destroy
3 participants