Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash caused by nil value in BigQuery Table #2113

Conversation

modular-magician
Copy link
Collaborator

Fixes: hashicorp/terraform-provider-google#17708

I don't want to add a test because it's impossible to provision a table with an empty string as the column. This now just triggers the correct 400 from the API rather than crashing

Release Note Template for Downstream PRs (will be copied)

bigquery: fixed a crash when `google_bigquery_table` had a `primary_key.columns` entry set to `""`

Derived from GoogleCloudPlatform/magic-modules#10319

[upstream:bfe6e935a2ecb1d1fc347b9aff11392d692be367]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner March 28, 2024 20:18
@modular-magician modular-magician requested review from melinath and removed request for a team March 28, 2024 20:18
@modular-magician modular-magician merged commit 9a16809 into GoogleCloudPlatform:main Mar 28, 2024
4 checks passed
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician deleted the downstream-pr-bfe6e935a2ecb1d1fc347b9aff11392d692be367 branch November 18, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant