-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash caused by nil value in BigQuery Table #10319
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slevenick
changed the title
Fix crash caused by nil value
Fix crash caused by nil value in BigQuery Table
Mar 28, 2024
slevenick
requested review from
a team and
zli82016
and removed request for
a team
March 28, 2024 19:45
Tests analyticsTotal tests: Click here to see the affected service packages
|
zli82016
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Mar 28, 2024
Merged
pjotrekk
pushed a commit
to pjotrekk/magic-modules
that referenced
this pull request
Apr 2, 2024
cmfeng
pushed a commit
to cmfeng/cmfeng-magic-modules
that referenced
this pull request
Apr 5, 2024
hao-nan-li
pushed a commit
to hao-nan-li/magic-modules
that referenced
this pull request
Apr 9, 2024
balanaguharsha
pushed a commit
to balanaguharsha/magic-modules
that referenced
this pull request
Apr 19, 2024
balanaguharsha
pushed a commit
to balanaguharsha/magic-modules
that referenced
this pull request
May 2, 2024
balanaguharsha
pushed a commit
to balanaguharsha/magic-modules
that referenced
this pull request
May 2, 2024
pawelJas
pushed a commit
to pawelJas/magic-modules
that referenced
this pull request
May 16, 2024
pengq-google
pushed a commit
to pengq-google/magic-modules
that referenced
this pull request
May 21, 2024
Cheriit
pushed a commit
to Cheriit/magic-modules
that referenced
this pull request
Jun 4, 2024
pcostell
pushed a commit
to pcostell/magic-modules
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: hashicorp/terraform-provider-google#17708
I don't want to add a test because it's impossible to provision a table with an empty string as the column. This now just triggers the correct 400 from the API rather than crashing
Release Note Template for Downstream PRs (will be copied)