Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash caused by nil value in BigQuery Table #10319

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented Mar 28, 2024

Fixes: hashicorp/terraform-provider-google#17708

I don't want to add a test because it's impossible to provision a table with an empty string as the column. This now just triggers the correct 400 from the API rather than crashing

Release Note Template for Downstream PRs (will be copied)

bigquery: fixed a crash when `google_bigquery_table` had a `primary_key.columns` entry set to `""`

@slevenick slevenick changed the title Fix crash caused by nil value Fix crash caused by nil value in BigQuery Table Mar 28, 2024
@slevenick slevenick requested review from a team and zli82016 and removed request for a team March 28, 2024 19:45
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 5 insertions(+))
google-beta provider: Diff ( 1 file changed, 5 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 113
Passed tests: 102
Skipped tests: 11
Affected tests: 0

Click here to see the affected service packages
  • bigquery

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slevenick slevenick merged commit bfe6e93 into GoogleCloudPlatform:main Mar 28, 2024
14 checks passed
pjotrekk pushed a commit to pjotrekk/magic-modules that referenced this pull request Apr 2, 2024
cmfeng pushed a commit to cmfeng/cmfeng-magic-modules that referenced this pull request Apr 5, 2024
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Apr 9, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants