Allow Prometheus to run GitHub Actions in e2e tests #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSpiritXIII
requested review from
pintohutch,
bwplotka,
bernot-dev and
maxamins
TheSpiritXIII
force-pushed
the
TheSpiritXIII/e2e-prometheus
branch
from
32975ca to
68ccf66
Compare
|
@TheSpiritXIII did you ever figure out what the issue was with the metricsClient auth disabling issue? |
Yes -- it was my fault. The arg wasn't originally taking because I was modifying the value in the for loop, which was being copied and not actually applied to the original object. In this PR, the for loop explicitly takes a reference to the container object to prevent that issue. |
pintohutch
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current e2e tests are not deploying the Prometheus collector pods correctly on GitHub Actions due to 2 reasons:
These issues cause the collector pods to crash loop indefinitely in e2e tests. cc @pintohutch