Add target status integration tests #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSpiritXIII
requested review from
pintohutch,
bwplotka,
bernot-dev and
maxamins
TheSpiritXIII
force-pushed
the
TheSpiritXIII/e2e-target-status2
branch
2 times, most recently
from
e3d07c4 to
e44f0b8
Compare
TheSpiritXIII
force-pushed
the
TheSpiritXIII/e2e-target-status2
branch
from
e44f0b8 to
f58d7f8
Compare
|
cc @bwplotka |
TheSpiritXIII
force-pushed
the
TheSpiritXIII/e2e-target-status2
branch
20 times, most recently
from
6dafdeb to
9d1c5e8
Compare
TheSpiritXIII
force-pushed
the
TheSpiritXIII/e2e-target-status2
branch
3 times, most recently
from
6582a07 to
907e15e
Compare
TheSpiritXIII
force-pushed
the
TheSpiritXIII/e2e-target-status2
branch
from
907e15e to
d4fc417
Compare
TheSpiritXIII
force-pushed
the
TheSpiritXIII/e2e-target-status2
branch
from
d4fc417 to
0b2a919
Compare
bwplotka
reviewed
Oct 9, 2023
| // To make tests simple and fast, the test suite runs the operator internally. The CRDs | ||
| // are expected to be installed out of band (along with the operator deployment itself in | ||
| // a real world setup). | ||
| package e2e |
There was a problem hiding this comment.
wowow - this is quite next level and quite innovating. Probably good for fun blog post / separate OSS lib / contribution to k8s testing libs or so 🙈
bwplotka
approved these changes
Oct 9, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly different approach from #395. The problem is that when we run an operator within the test, the HTTP client cannot resolve Pod IP addresses. The resolve this, I created a custom HTTP client which can do this.
This PR builds on top of #613 since we now check if collectors are ready before checking whether target status is working.