Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version used in CI to 1.23.1 #891

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Sep 10, 2024

This adds support for go 1.23.1, and also fixes the govulncheck presubmit failure

I seem to have hit golang/go#68978, so the second commit updates our tooling dependencies.

Then I hit golangci/golangci-lint#3280, and had to update linter rules.

@dashpole dashpole requested a review from a team as a code owner September 10, 2024 18:19
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 62.91%. Comparing base (4caace7) to head (e5de7f8).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
...er/collector/integrationtest/protos/fixtures.pb.go 0.00% 4 Missing ⚠️
internal/resourcemapping/resourcemapping.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
+ Coverage   61.03%   62.91%   +1.88%     
==========================================
  Files          56       57       +1     
  Lines        5903     6011     +108     
==========================================
+ Hits         3603     3782     +179     
+ Misses       2143     2067      -76     
- Partials      157      162       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dashpole dashpole merged commit a6eab1e into GoogleCloudPlatform:main Sep 11, 2024
33 of 34 checks passed
@dashpole dashpole deleted the update_go_123 branch September 11, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants