Update go version used in CI to 1.23.1 (#891)

* update go version used in CI to 1.23.1

* update all tool dependencies

* fix linter

* make generate

.github/workflows/ci.yml

@@ -7,7 +7,7 @@ on:
   pull_request:
 env:
   # Default minimum version of Go to support.
-  DEFAULT_GO_VERSION: "1.22.5"
+  DEFAULT_GO_VERSION: "1.23.1"
 jobs:
   lint:
     runs-on: ubuntu-latest
@@ -107,7 +107,7 @@ jobs:
   compatibility-test:
     strategy:
       matrix:
-        go-version: ["1.22.3", "1.21"]
+        go-version: ["1.23.1", "1.22.5", "1.21"]
         os: [ubuntu-latest, macos-latest, windows-latest]
         arch: ["386", amd64]
         exclude:

cloudbuild-e2e-cloud-functions-gen2.yaml

@@ -14,7 +14,7 @@
 
 steps:
   # Vendor dependencies, and zip the code.
-  - name: golang:1.22.3
+  - name: golang:1.23.1
     id: zip-code
     entrypoint: /bin/bash
     args:

cloudbuild-e2e-gae-standard.yaml

@@ -14,7 +14,7 @@
 
 steps:
   # Vendor dependencies, and zip the code.
-  - name: golang:1.22.2
+  - name: golang:1.23.1
     id: zip-code
     entrypoint: /bin/bash
     args:

cloudbuild-integration-tests.yaml

@@ -13,7 +13,7 @@
 # limitations under the License.
 
 steps:
-  - name: golang:1.22.3
+  - name: golang:1.23.1
     env: ["SECOND_PROJECT_ID=opentelemetry-ops-e2e-2"]
     args: ["make", "integrationtest"]
 logsBucket: gs://opentelemetry-ops-e2e-cloud-build-logs

e2e-test-server/Dockerfile

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-FROM golang:1.22.3 as builder
+FROM golang:1.23.1 as builder
 
 WORKDIR /workspace/e2e-test-server/
 

golangci.yml

@@ -26,10 +26,6 @@ run:
   # on Windows.
   skip-dirs:
 
-  # default is true. Enables skipping of directories:
-  #   vendor$, third_party$, testdata$, examples$, Godeps$, builtin$
-  skip-dirs-use-default: false
-
   # which files to skip: they will be analyzed, but issues from them
   # won't be reported. Default value is empty list, but there is
   # no need to include all autogenerated files, we confidently recognize
@@ -56,7 +52,7 @@ run:
 # output configuration options
 output:
   # colored-line-number|line-number|json|tab|checkstyle|code-climate, default is "colored-line-number"
-  format: colored-line-number
+  formats: colored-line-number
 
   # print lines of code with issue, default is true
   print-issued-lines: true
@@ -71,29 +67,20 @@ output:
 # all available settings of specific linters
 linters-settings:
   depguard:
-    # Check the list against standard lib.
-    # Default: false
-    include-go-root: true
-    # A list of packages for the list type specified.
-    # Default: []
-    packages:
-      - "crypto/md5"
-      - "crypto/sha1"
-      - "crypto/**/pkix"
-    ignore-file-rules:
-      - "**/*_test.go"
-    additional-guards:
-      # Do not allow testing packages in non-test files.
-      - list-type: denylist
-        include-go-root: true
-        packages:
-          - testing
-          - github.com/stretchr/testify
-        ignore-file-rules:
-          - "**/*_test.go"
-          - "**/*test/*.go"
-          - "**/testcase.go"
-          - "**/recordfixtures/*.go"
+    rules:
+      non-tests:
+        files:
+          - "!$test"
+          - "!**/testcase.go"
+          - "!**/*test/*.go"
+          - "!**/*recordfixtures/*.go"
+          - "!**/internal/matchers/*.go"
+        deny:
+          - pkg: "testing"
+          - pkg: "github.com/stretchr/testify"
+          - pkg: "crypto/md5"
+          - pkg: "crypto/sha1"
+          - pkg: "crypto/**/pkix"
   godot:
     exclude:
       # Exclude sentence fragments for lists.
@@ -113,7 +100,7 @@ linters-settings:
     min-confidence: 0.8
   govet:
     # report about shadowed variables
-    check-shadowing: true
+    shadow: true
 
     # settings per analyzer
     settings:
@@ -153,8 +140,9 @@ linters-settings:
       - name: constant-logical-expr
         disabled: false
       # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#context-as-argument
+      # TODO reenable linter when it is compatible. https://github.com/golangci/golangci-lint/issues/3280
       - name: context-as-argument
-        disabled: false
+        disabled: true
         arguments:
           allowTypesBefore: "*testing.T"
       # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#context-keys-type
@@ -292,7 +280,7 @@ linters:
   enable:
     - depguard
     - errcheck
-    - exportloopref
+    - copyloopvar
     - godot
     - gofmt
     - goimports
@@ -322,3 +310,4 @@ issues:
     - path: \.pb\.go
       linters:
         - govet
+  exclude-dirs-use-default: false

internal/resourcemapping/resourcemapping.go

@@ -221,9 +221,8 @@ func commonResourceAttributesToMonitoredResource(cloudPlatform string, attrs Rea
 				return createMonitoredResource(k8sPod, attrs)
 			} else if _, ok := attrs.GetString(string(semconv.K8SNodeNameKey)); ok {
 				return createMonitoredResource(k8sNode, attrs)
-			} else {
-				return createMonitoredResource(k8sCluster, attrs)
 			}
+			return createMonitoredResource(k8sCluster, attrs)
 		}
 
 		// Fallback to generic_task