-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for capacity aware modes to `google_compute_region_instance_group_manager #4348
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
71c3aeb
Merge pull request #1 from GoogleCloudPlatform/master
upodroid e1a9488
Merge branch 'master' of github.com:GoogleCloudPlatform/magic-modules
upodroid 51eaff6
Merge branch 'master' of github.com:GoogleCloudPlatform/magic-modules
upodroid 649e97c
Merge branch 'master' of github.com:GoogleCloudPlatform/magic-modules
upodroid ee373cc
Merge branch 'master' of github.com:GoogleCloudPlatform/magic-modules
upodroid d330773
Merge branch 'master' of github.com:GoogleCloudPlatform/magic-modules
upodroid 0d73e9f
Merge branch 'master' of github.com:GoogleCloudPlatform/magic-modules
upodroid 191a775
Merge branch 'master' of github.com:GoogleCloudPlatform/magic-modules
upodroid d13766b
add dpts to RIGM
upodroid ffa6193
typo fix
upodroid dddd728
add doc note
upodroid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to set the target shape if the distribution policy zones are empty? We are opening the possibility of an empty list of zones here, which seems like it might cause problems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. Also, there a number of limitations that appear once you set target shape which are not validated in terraform.
https://cloud.google.com/compute/docs/instance-groups/regional-mig-distribution-shape
https://cloud.google.com/compute/docs/instance-groups/distributing-instances-with-regional-instance-groups#setting_a_policy_for_distributing_instances_across_zones