-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for capacity aware modes to `google_compute_region_instance_group_manager #4348
Conversation
Fork Update
Co-authored-by: upodroid <[email protected]>
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @slevenick, please review this PR or find an appropriate assignee. |
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add possible values or a link to the documentation. Other comment about empty zones is more of a question
third_party/terraform/website/docs/r/compute_region_instance_group_manager.html.markdown
Outdated
Show resolved
Hide resolved
func expandDistributionPolicy(d *schema.ResourceData) *computeBeta.DistributionPolicy { | ||
dpz := d.Get("distribution_policy_zones").(*schema.Set) | ||
dpts := d.Get("distribution_policy_target_shape").(string) | ||
if dpz.Len() == 0 && dpts == "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to set the target shape if the distribution policy zones are empty? We are opening the possibility of an empty list of zones here, which seems like it might cause problems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. Also, there a number of limitations that appear once you set target shape which are not validated in terraform.
https://cloud.google.com/compute/docs/instance-groups/regional-mig-distribution-shape
/gcbrun Should work now that the API client is updated |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=168385" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes: hashicorp/terraform-provider-google#8002
You also need to bump the API library to v0.36.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)