Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for capacity aware modes to `google_compute_region_instance_group_manager #4348

Merged
merged 11 commits into from
Jan 21, 2021

Conversation

upodroid
Copy link
Contributor

Fixes: hashicorp/terraform-provider-google#8002

You also need to bump the API library to v0.36.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `distribution_policy_target_shape` field to `google_compute_region_instance_group_manager` resource

@google-cla google-cla bot added the cla: yes label Dec 23, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 35 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 3 files changed, 35 insertions(+), 13 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 35 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 3 files changed, 35 insertions(+), 13 deletions(-))

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add possible values or a link to the documentation. Other comment about empty zones is more of a question

func expandDistributionPolicy(d *schema.ResourceData) *computeBeta.DistributionPolicy {
dpz := d.Get("distribution_policy_zones").(*schema.Set)
dpts := d.Get("distribution_policy_target_shape").(string)
if dpz.Len() == 0 && dpts == "" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to set the target shape if the distribution policy zones are empty? We are opening the possibility of an empty list of zones here, which seems like it might cause problems

Copy link
Contributor Author

@upodroid upodroid Jan 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 35 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 4 files changed, 36 insertions(+), 14 deletions(-))

@slevenick
Copy link
Contributor

/gcbrun

Should work now that the API client is updated

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=168385"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 35 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 4 files changed, 36 insertions(+), 14 deletions(-))

@slevenick slevenick self-requested a review January 21, 2021 23:17
Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for capacity aware modes in google_compute_region_instance_group_manager
3 participants