Add support for INTERNAL_SELF_MANAGED backend service #1833

slevenick · 2019-05-24T20:18:01Z

Add support for INTERNAL_SELF_MANAGED backend service and global forwarding rules

[all]

[terraform]

[terraform-beta]

Add support for internal self managed load balancing

[ansible]

[inspec]

modular-magician · 2019-05-24T20:30:32Z

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 707c88c.

Pull request statuses

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#772
depends: GoogleCloudPlatform/terraform-google-conversion#88
depends: hashicorp/terraform-provider-google#3719
depends: modular-magician/ansible#265
depends: modular-magician/inspec-gcp#158

danawillow

Ooh I think this means that allowing internal load balancing with global backend services. Can you take a look at #1689 and see if we need to update docs that were changed then?

Also @rileykarson fyi

slevenick · 2019-05-28T22:02:57Z

Ooh I think this means that allowing internal load balancing with global backend services. Can you take a look at #1689 and see if we need to update docs that were changed then?

Also @rileykarson fyi

I don't think we need to change any of those back. I've been testing settings like balancing_mode = "RATE" and other settings that previously were disallowed for internal balancers. From what I understand the INTERNAL_SELF_MANAGED balancers allow HTTP(s) and all of the settings that were previously only allowed on global external backend services

modular-magician · 2019-05-28T22:36:16Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, c337d1a.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

slevenick · 2019-05-29T16:35:30Z

templates/terraform/examples/backend_service_global_internal.tf.erb

@@ -0,0 +1,100 @@
+resource "google_compute_global_forwarding_rule" "default" {


Does it make sense for this file to be part of the examples? I can also make it a separate test file.

What is best practice on this sort of thing?

Unfortunately it's a bit of a best-judgment thing right now. I'd say for this one since global forwarding rules need backend services but not the other way around, that this example belongs with global forwarding rule and not backend service. My inclination is that the docs page should have realistic-ish examples, but not too many of them. So since this reads as a pretty typical way to set up load balancing, I'd say putting it in the docs is perfectly reasonable, but adding 5 more examples with different tweaks of the configuration wouldn't be.

One thing to be aware of with beta fields are that the generated tests don't have the import step, so it's a good idea to verify those manually as well.

Also it looks like the GFR docs didn't get generated for some reason, not really sure what's going on there.

slevenick · 2019-05-29T16:35:43Z

templates/terraform/examples/global_forwarding_rule_internal.tf.erb

@@ -0,0 +1,59 @@
+resource "google_compute_global_forwarding_rule" "default" {


Same as above

modular-magician · 2019-05-29T20:36:41Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, add1834.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-05-29T20:56:48Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b874de2.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

danawillow · 2019-05-29T23:08:20Z

third_party/terraform/tests/resource_compute_backend_service_test.go.erb

@@ -637,6 +637,34 @@ func TestAccComputeBackendService_withCustomHeaders(t *testing.T) {
 }
 <% end -%>

+<% unless version == 'ga' -%>


This hand-written test is only necessary in order to do the import part, right? If so, can you add a comment to remove it once the feature goes GA (since then we'd get import for the example test)?

modular-magician · 2019-05-29T23:15:17Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, a16bad3.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

modular-magician · 2019-05-31T20:21:07Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 9d100ae.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

…arding rule

…ion update

googlebot added the cla: yes label May 24, 2019

modular-magician added downstream-generated ansible inspec terraform-google-conversion terraform-provider-google-beta terraform-provider-google labels May 24, 2019

slevenick requested a review from danawillow May 24, 2019 20:58

danawillow reviewed May 24, 2019

View reviewed changes

slevenick requested a review from danawillow May 28, 2019 22:38

slevenick commented May 29, 2019

View reviewed changes

danawillow approved these changes May 29, 2019

View reviewed changes

slevenick force-pushed the internal-self-managed-backend branch from d5a736e to 9d100ae Compare May 31, 2019 20:07

modular-magician added the automerged label May 31, 2019

slevenick added 6 commits May 31, 2019 21:28

Add support for INTERNAL_SELF_MANAGED backend service and global forw…

ba53b02

…arding rule

Add test for global INTERNAL_SELF_MANAGED backend service. Documentat…

92e26ad

…ion update

Add manual testing

5fc7008

Add min_version to network for glb

5cd75dd

Remove unnecessary test step

b3d39dd

Add comment to test

8914332

modular-magician force-pushed the internal-self-managed-backend branch from 9d100ae to 8914332 Compare May 31, 2019 21:28

modular-magician merged commit c9ece49 into GoogleCloudPlatform:master May 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for INTERNAL_SELF_MANAGED backend service #1833

Add support for INTERNAL_SELF_MANAGED backend service #1833

slevenick commented May 24, 2019

modular-magician commented May 24, 2019

danawillow left a comment

slevenick commented May 28, 2019

modular-magician commented May 28, 2019

slevenick May 29, 2019

danawillow May 29, 2019

slevenick May 29, 2019

modular-magician commented May 29, 2019

modular-magician commented May 29, 2019

danawillow May 29, 2019

modular-magician commented May 29, 2019

modular-magician commented May 31, 2019

		@@ -0,0 +1,100 @@
		resource "google_compute_global_forwarding_rule" "default" {

		@@ -0,0 +1,59 @@
		resource "google_compute_global_forwarding_rule" "default" {

Add support for INTERNAL_SELF_MANAGED backend service #1833

Add support for INTERNAL_SELF_MANAGED backend service #1833

Conversation

slevenick commented May 24, 2019

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

modular-magician commented May 24, 2019

Pull request statuses

New Pull Requests

danawillow left a comment

Choose a reason for hiding this comment

slevenick commented May 28, 2019

modular-magician commented May 28, 2019

Pull request statuses

New Pull Requests

slevenick May 29, 2019

Choose a reason for hiding this comment

danawillow May 29, 2019

Choose a reason for hiding this comment

slevenick May 29, 2019

Choose a reason for hiding this comment

modular-magician commented May 29, 2019

Pull request statuses

New Pull Requests

modular-magician commented May 29, 2019

Pull request statuses

New Pull Requests

danawillow May 29, 2019

Choose a reason for hiding this comment

modular-magician commented May 29, 2019

Pull request statuses

New Pull Requests

modular-magician commented May 31, 2019

Pull request statuses

New Pull Requests