Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BackendService docs / schema to reflect being GLB only #1689

Merged
merged 4 commits into from
Apr 30, 2019
Merged

Update BackendService docs / schema to reflect being GLB only #1689

merged 4 commits into from
Apr 30, 2019

Conversation

rileykarson
Copy link
Member

Similar to clarifications in #1627

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@rileykarson rileykarson requested a review from emilymye April 26, 2019 15:35
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 15d05f2.

Pull request statuses

No diff detected in terraform-google-conversion.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#638
depends: hashicorp/terraform-provider-google#3503
depends: modular-magician/ansible#237
depends: modular-magician/inspec-gcp#152

emilymye
emilymye approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@emilymye emilymye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this is also an optional change (since I was going to just open a new PR to do this) but during my LB testing I realized that loadBalancingScheme is non-updatable - even though it's listed on update/ docs allowed fields, the API returns an error (I filed a bug against the team). I don't know if we want to enforce input=true on our side, but if you want to tuck that in here, I'd be ok with that.

@rileykarson rileykarson changed the title Update BackendService docs to reflect being GLB only Update BackendService docs / schema to reflect being GLB only Apr 26, 2019
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 815075a.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician modular-magician merged commit 99fd810 into GoogleCloudPlatform:master Apr 30, 2019
@modular-magician modular-magician mentioned this pull request May 1, 2019
Merged
@slevenick slevenick mentioned this pull request May 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambleraptor rambleraptor rambleraptor left review comments

@pdecat pdecat pdecat left review comments

@emilymye emilymye emilymye approved these changes

Assignees
No one assigned
Labels
ansible automerged cla: yes downstream-generated inspec terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rileykarson @modular-magician @pdecat @rambleraptor @emilymye @googlebot