-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
privateca: update certificate authority samples with more realistic values #12259
privateca: update certificate authority samples with more realistic values #12259
Conversation
…alues Some of the properties configured here are either wrong or at least not very sensible on root certificates / subordinates. A similar set of fixes got applied to terraform documentation samples in terraform-google-modules/terraform-docs-samples#631 Signed-off-by: Sven Hoexter <[email protected]>
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of the reason these samples are structured in this way is to ensure that every field is covered in a create test - this is important to make sure the resources work as expected. Given the number of fields removed here, I'm guessing the coverage is no longer complete.
You can use exclude_docs
on a complete (but impractical) example to have it be used only for test generation, and have the examples being used in docs be less complete.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 39 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, the fields are all still covered!
LGTM |
…alues (GoogleCloudPlatform#12259) Signed-off-by: Sven Hoexter <[email protected]>
…alues (GoogleCloudPlatform#12259) Signed-off-by: Sven Hoexter <[email protected]>
Some of the properties configured here are either wrong or at least not very sensible on root certificates / subordinates.
A similar set of fixes got applied to terraform documentation samples in terraform-google-modules/terraform-docs-samples#631
What is left out here is placing the subordinate CA in it's own pool. I could not figure out what is required here to prepare the test infrastructure to provision another pool dedicated to the sub-ca. Technically those two certificates should not reside in the same pool.