-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pure python entrypoints to unbreak skaffold debugging #501
Use pure python entrypoints to unbreak skaffold debugging #501
Conversation
Hi Jay, could you please provide a bit more context on why this PR is needed? It does seem like the underlying bug that caused our gunicorn issues -- benoitc/gunicorn#1913 -- has been fixed, and gunicorn has put out an updated release. but I'd rather not do another backend overhaul unless there's a concrete benefit behind doing so. |
Hi @askmeegs! I provided some rationale and encountered error messages in the linked issue, but the TLDR is that running |
src/userservice/Dockerfile
Outdated
@@ -1,4 +1,4 @@ | |||
# Copyright 2021 Google LLC | |||
# Copyright 2019 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: license should be 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated all touched files to have the correct copyright year.
Thanks for the review @kelsk! I addressed your comment. PTAL. |
@j-windsor perfect, thanks! @askmeegs For a little more context, the main goal of configuring Bank of Anthos to be debuggable using Cloud Code/ If it's not feasible to revert back to using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally in a GKE cluster, and a cluster with Anthos Service Mesh. LGTM.
No readiness probe issues observed. (which was the gunicorn bug that caused us to move to uwsgi - ). Will need to keep an eye on this. #447
Fixes #500.
Change summary:
uwsgi
.locust
directly instead of from a bash script. Dockerfile was modified to support debugging locust files.Debugging will still not work until this is fixed on the skaffold side: https://github.com/GoogleContainerTools/container-debug-support/issues/83