Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python debugging entrypoint rewrite incorrect if it contains parenthesis. #6100

Closed
j-windsor opened this issue Jun 9, 2021 · 0 comments · Fixed by #6101
Closed

Python debugging entrypoint rewrite incorrect if it contains parenthesis. #6100

j-windsor opened this issue Jun 9, 2021 · 0 comments · Fixed by #6101
Assignees
Labels
area/debug kind/bug Something isn't working priority/p0 Highest priority. We are actively looking at delivering it.

Comments

@j-windsor
Copy link

Description of the issue:
on skaffold debug was getting the error > [contacts-85bf9984d6-hlfkp contacts] /bin/sh: 1: Syntax error: "(" unexpected, so I escaped the parenthesis, which fixed debug, but caused dev to error with > [contacts-8668d9cdbb-f9xch contacts] Failed to parse 'create_app\\(\\)' as an attribute name or function call. It seems like the rewrite of the entrypoint during debug is causing some string escaping issues?

Expected behavior:
I do not have to escape the parenthesis and it will work in both dev and debug.

Steps to reproduce:

  1. use Use pure python entrypoints to unbreak skaffold debugging GoogleCloudPlatform/bank-of-anthos#501 (note that the parenthesis are not escaped)
  2. skaffold dev works :)
  3. skaffold debug does not work :(

Environment:
OS: macOS v11.4
Skaffold: v1.25.0

@briandealwis briandealwis transferred this issue from GoogleContainerTools/container-debug-support Jun 28, 2021
@briandealwis briandealwis added area/debug kind/bug Something isn't working priority/p0 Highest priority. We are actively looking at delivering it. labels Jun 28, 2021
@briandealwis briandealwis self-assigned this Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/debug kind/bug Something isn't working priority/p0 Highest priority. We are actively looking at delivering it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants