Skip to content
This repository has been archived by the owner on Jan 23, 2021. It is now read-only.

Friendlier error messages for two types of bad parameters. #45

Merged
merged 2 commits into from
Nov 2, 2015
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion lib/sw-precache.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,29 @@ function generate(params, callback) {
});

Object.keys(params.dynamicUrlToDependencies).forEach(function(dynamicUrl) {
if (!Array.isArray(params.dynamicUrlToDependencies[dynamicUrl])) {
throw Error(util.format(
'The value for the dynamicUrlToDependencies.%s option must be an Array.', dynamicUrl));
}

var filesAndSizesAndHashes = params.dynamicUrlToDependencies[dynamicUrl]
.sort()
.map(getFileAndSizeAndHashForFile);
.map(function(file) {
try {
return getFileAndSizeAndHashForFile(file);
} catch (e) {
// Provide some additional information about the failure if the file is missing.
if (e.code === 'ENOENT') {
params.logger(util.format(
'%s was listed as a dependency for dynamic URL %s, but the file does not exist. ' +
'Either remove the entry as a dependency, or correct the path to the file.',
file, dynamicUrl
));
}
// Re-throw the exception unconditionally, since this should be treated as fatal.
throw e;
}
});
var concatenatedHashes = '';

filesAndSizesAndHashes.forEach(function(fileAndSizeAndHash) {
Expand Down